chore: add automation for release keys - #2603
Conversation
|
I'm not sure if it should be part of the documented advice, but I would recommend disabling the workflow Automatically update Docker image versions before merging a PR with only key changes. That prevents immediate PR creation for a new Docker version release, and delays updating |
4f42b8e to
141878f
Compare
|
@MikeMcC399 I changed the cron frequency to weekly, and added a |
141878f to
35ab84d
Compare
|
Running this workflow will fix the keys order difference described in #2569. |
|
@nodejs/releasers would it make sense to include your group as "reviewers" in the generated PRs for visibility, or would that just be noise? |
|
I'm not sure a cron is the correct way forward, a linter would be much better, avoiding "invalid" data to be merged in rather than correcting it after-the-fact |
29aa9b3 to
03c8ad4
Compare
03c8ad4 to
c726a99
Compare
|
@aduh95 I added a second plain CI/check action too. I can keep both, or drop the cron one if you think the releasers prefer to open the PRs here manually |
|
I'm not sure, an automated process makes it easier for a "bad" change to make its way here (i.e. someone getting write access to release-keys to affect docker-node); it really depends on thorough the review process actually is for this kind of automated PRs |
|
I suggest to go ahead with landing this PR. It does not introduce any new risks, and helps ensure that the key list is aligned. All PRs are subject to approval by the @nodejs/docker team and there is no automated key list update in this repo that takes place without approval. |
|
I suggest getting a green CI first. If there are automated PRs, mandating reviews from releasers as suggested in #2603 (comment) makes sense |
|
The CI failure is due to the mismatched ordering of keys: If the error is not corrected prior to this PR landing, or as part of the PR, then it would have the advantage of exercising the automated key mismatch detection, PR correction creation and approval process. I would defer to @nschonni for that decision. |
Description
Either a test job in CI could run if someone touches the keys file, or a periodic sync can just check for changes and create a PR. I opted for the later, but the former would work as well.
Motivation and Context
#2569
I assume that a daily poll is more than frequent enough, although it's possible that a new Releaser could open the PR manually here while the other upstream PRs are waiting. Any sort issues would eventually get corrected by the PR this action would create.
Potentially the upstream documentation to open the PR here for the keys could be removed if this lands.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist